mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38530: CMake: Add preprocessor definitions required to build picojson 1.3.0.
Date Mon, 21 Sep 2015 17:58:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38530/#review99780
-----------------------------------------------------------

Ship it!



cmake/MesosConfigure.cmake (lines 121 - 123)
<https://reviews.apache.org/r/38530/#comment156756>

    Can you also copy in the note?
    
    ```
    # NOTE: PicoJson requires __STDC_FORMAT_MACROS to be defined before importing
    # 'inttypes.h'.  Since other libraries may also import this header, it must
    # be globally defined so that PicoJson has access to the macros, regardless
    # of the order of inclusion.
    ```


- Joseph Wu


On Sept. 19, 2015, 7:07 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38530/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 7:07 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-3345
>     https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> CMake: Add preprocessor definitions required to build picojson 1.3.0.
> 
> 
> Diffs
> -----
> 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/38530/diff/
> 
> 
> Testing
> -------
> 
> Compiled and ran made sure libprocess and stout tests ran and passed on the following
platforms:
> 
> * OS X 10.10
> * Windows 10
> * Ubuntu 14.04.2
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message