mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 38535: Fix ExamplesTest errors when user is root.
Date Mon, 21 Sep 2015 17:50:31 GMT


> On Sept. 21, 2015, 5:16 p.m., Jie Yu wrote:
> > src/slave/containerizer/linux_launcher.cpp, lines 184-186
> > <https://reviews.apache.org/r/38535/diff/3/?file=1077669#file1077669line184>
> >
> >     Could you please explain where the bug is in the description. I don't understand
why this code is buggy.

Because we have multi slaves, this share memory would be override in different threads. So
that all threads would got the same "pipes" and same execute "function" pointer.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99764
-----------------------------------------------------------


On Sept. 20, 2015, 5:04 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 5:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and Michael Park.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp dde552ff2a9d29c31f7676180fffa19d1fb0ba63

> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message