mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.
Date Mon, 21 Sep 2015 03:23:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38542/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Currently we configure the version information of third-party
dependencies in the CMake build system from magic strings.

This commit will transition away from the magic string solution and
towards the variables we define in `Versions.cmake`.


Diffs
-----

  3rdparty/libprocess/cmake/ProcessConfigure.cmake a5f8d399e151acad87bb72ecb1f7372b2c467423

  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9e4dcb83a8cc4e95a2a38573944f6b38e2eac76e


Diff: https://reviews.apache.org/r/38542/diff/


Testing
-------

Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message