mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.
Date Mon, 21 Sep 2015 02:33:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38538/
-----------------------------------------------------------

Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van Remoortere, and Joseph
Wu.


Bugs: MESOS-3434
    https://issues.apache.org/jira/browse/MESOS-3434


Repository: mesos


Description
-------

This was originally part of this review[1] by haosdent. It was split out
and moved into the root folder by hausdorff, because we will later reuse
it to build other third-party libraries on Windows that are not only in
libprocess, and hence it belongs outside of the commits that touch
libprocess.

But, the code is essentially haosdent's, so the credit should go to him.

[1] Original review: https://reviews.apache.org/r/37273


Diffs
-----

  CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
  cmake/Common.cmake PRE-CREATION 

Diff: https://reviews.apache.org/r/38538/diff/


Testing
-------

Compiled and ran made sure libprocess and stout tests ran and passed on the following platforms:

* OS X 10.10
* Windows 10
* Ubuntu 14.04.2


Thanks,

Alex Clemmer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message