mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38519: Change function quiesce() to suppressRes()
Date Mon, 21 Sep 2015 00:50:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38519/#review99718
-----------------------------------------------------------



src/master/http.cpp (line 486)
<https://reviews.apache.org/r/38519/#comment156700>

    'suppressRes' is weird. this got to be 'suppress'. we need to figure out how to resolve
the conflict with the macro.


- Vinod Kone


On Sept. 19, 2015, 1:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38519/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2015, 1:26 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The reason that I was not using suppress() is because suppress is
> already defined in
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 7cca8b1d3118fe99de79cfaf5360825012d830da 
>   src/master/master.hpp 6805177d7c03b701708e1d217a7bc0ac7c79889e 
>   src/master/master.cpp 64e5fb9e27b2e6797b2ce87c0e1a3ef8a2943e27 
> 
> Diff: https://reviews.apache.org/r/38519/diff/
> 
> 
> Testing
> -------
> 
> Platform: Ubuntu:14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message