mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 38535: Fix ExamplesTest errors when user is root.
Date Sun, 20 Sep 2015 16:40:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38535/#review99704
-----------------------------------------------------------

Ship it!


Thanks for the catch!! LGTM module the memory leak.


src/slave/containerizer/linux_launcher.cpp (line 199)
<https://reviews.apache.org/r/38535/#comment156687>

    We need to free up the memory allocated above. It should be safe to do so after the clone
call returns since it creates a new process.


- Kapil Arya


On Sept. 20, 2015, 12:08 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38535/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2015, 12:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Joris Van Remoortere, Kapil Arya, and Michael Park.
> 
> 
> Bugs: MESOS-3474
>     https://issues.apache.org/jira/browse/MESOS-3474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix ExamplesTest errors when user is root.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/linux_launcher.cpp dde552ff2a9d29c31f7676180fffa19d1fb0ba63

> 
> Diff: https://reviews.apache.org/r/38535/diff/
> 
> 
> Testing
> -------
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="ExamplesTest.*" --verbose
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message