mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38051: Only update the task status when its old status is not terminal.
Date Fri, 18 Sep 2015 21:18:44 GMT


> On Sept. 17, 2015, 10:25 p.m., Vinod Kone wrote:
> > Can you write a test for this?
> 
> Yong Qiao Wang wrote:
>     I find the code changes in this patch does not be tested with an end-to-end case
except to check the error log messages of master, so my test strategy are:
>     
>     1. Change the python test executor to send the TASK_FINASHED with two times;
>     2. Check the error log message of maser;
>     
>     Test passwd!
>     
>     Vinod, I am not familiar with current test framework of mesos, cloud you provide
some similar test code, and I can refer to write my test case for this. Thanks!

Instaed of updating python executor, write a self-contained unit test. Take a look at "UnacknowledgedTerminalTask"
and "ReleaseResourcesForTerminalTaskWithPendingUpdates" in src/tests/master_tests.cpp for
inspiration on how to write such a test.

Also, instead of sending TASK_FINISHED multiple times, have the executor send TASK_FINISHED
followed by a TASK_KILLED. That way you can check that the status of the task hasn't changed
in the master.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38051/#review99453
-----------------------------------------------------------


On Sept. 18, 2015, 7:15 a.m., Yong Qiao Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38051/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2015, 7:15 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2864
>     https://issues.apache.org/jira/browse/MESOS-2864
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only update the task status when its old status is not terminal.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 1c4e7af 
> 
> Diff: https://reviews.apache.org/r/38051/diff/
> 
> 
> Testing
> -------
> 
> UT:
> 
> 1. make successfully!
> 2. make check successfully!
> 3. Run test framework successfully!
> 
> 
> Thanks,
> 
> Yong Qiao Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message