mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park" <mcyp...@gmail.com>
Subject Re: Review Request 38347: Add HELP Message for Reserve/Unreserve endpoint
Date Fri, 18 Sep 2015 18:14:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38347/#review99574
-----------------------------------------------------------



src/master/http.cpp (line 669)
<https://reviews.apache.org/r/38347/#comment156499>

    How about: `Reserve resources dynamically on a specific slave.`?



src/master/http.cpp (line 671)
<https://reviews.apache.org/r/38347/#comment156502>

    How about: `s/if dynamic reserve resource successfully/if resource reservation was successful.`?



src/master/http.cpp (line 1788)
<https://reviews.apache.org/r/38347/#comment156503>

    Same as above.



src/master/http.cpp (line 1790)
<https://reviews.apache.org/r/38347/#comment156504>

    Same as above.



src/master/http.cpp (line 1792)
<https://reviews.apache.org/r/38347/#comment156505>

    We should keep this consistent with above, as in: `s/resources going to be/resources to
be/`


- Michael Park


On Sept. 15, 2015, 1:04 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38347/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 1:04 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3419
>     https://issues.apache.org/jira/browse/MESOS-3419
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add HELP Message for Reserve/Unreserve endpoint
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/master/master.cpp f26271c5b21685916c0654488ac1464f21d72e9a 
> 
> Diff: https://reviews.apache.org/r/38347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message