mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.
Date Thu, 17 Sep 2015 21:58:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 2:58 p.m.)


Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.


Changes
-------

The previous version had a bug which caused unable to clean up multiple mounts and it masked
another issue in filesystem tests that rootfses are not put under a directory with the container
ID in its path. This caused some mounts such as the persistent volumes which belonged to the
same container to be mistakenly cleaned up!


Bugs: MESOS-3433
    https://issues.apache.org/jira/browse/MESOS-3433


Repository: mesos


Description
-------

Implemented a TODO to clean up host mounts irrelevant to the container in the container's
mount namespace.


Diffs (updated)
-----

  src/slave/containerizer/isolators/filesystem/linux.hpp 99f939f8b254cf71b4c1c7829b5fa37abdc2771b

  src/slave/containerizer/isolators/filesystem/linux.cpp b6746345b70b462123c3254065e4f09a42f45e5b

  src/tests/containerizer/filesystem_isolator_tests.cpp ca9f423d5f2f8f838c3371ee596f07537bb45210


Diff: https://reviews.apache.org/r/38447/diff/


Testing
-------

Added a test that is not specific for this but observed successful cleanup of the other container's
mounts in logs.


Thanks,

Jiang Yan Xu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message