mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38030: [2/5] Integer Precision for JSON <-> Protobuf conversions.
Date Thu, 17 Sep 2015 19:17:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38030/#review99423
-----------------------------------------------------------



src/Makefile.am (line 111)
<https://reviews.apache.org/r/38030/#comment156314>

    Have you guys looked at the code in the picojson?
    https://github.com/kazuho/picojson/blob/master/picojson.h#L61
    
    Looks like that macro should be defined. I don't understand why this fixed the issue.


- Jie Yu


On Sept. 17, 2015, 7:13 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38030/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 7:13 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, and Vinod
Kone.
> 
> 
> Bugs: MESOS-3345
>     https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add `PICOJSON_USE_INT64` and `__STDC_FORMAT_MACROS` flag to mesos compilation flags.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 2286366852b272c808490b6bd87ac9e894de57ac 
> 
> Diff: https://reviews.apache.org/r/38030/diff/
> 
> 
> Testing
> -------
> 
> No testing done until the last patch in the chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message