mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <>
Subject Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.
Date Thu, 17 Sep 2015 19:14:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Sept. 17, 2015, 12:14 p.m.)

Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Michael Park,
and Vinod Kone.


Re-opening with fixes for g++ 4.8/4.9 on CentOS 7.

Bugs: MESOS-3345

Repository: mesos


* Changes JSON::Number to keep track of whether it is floating, signed integral, or unsigned
* Changes how JSON::Number is stringified, to ensure that stringified doubles are parsed as
JSON doubles.
* Added one test for integer precision between String <-> JSON <-> Protobuf conversions.
* Added one test for JSON::Number comparisons.

Diffs (updated)

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c4682c41e94ab6c7641a78d66b2f9daa5f

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 115cc0cbec04db1bd9e068263f3931f33c266e86

  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c269e9be24c0f1ae81b8aa8725f8a0c151

  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp 87737dd1669ee77db2f29dacd8b5cebb0cabc0e6



No testing done until the last patch in the chain.

However, this patch does breaks some libprocess and mesos tests (because JSON::Number is stored
differently), which are fixed in the following two reviews.


Joseph Wu

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message