mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38399: Add ACLs for the maintenance HTTP endpoints
Date Thu, 17 Sep 2015 16:59:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38399/#review99402
-----------------------------------------------------------


Note: I was hoping you would put changes in the docs and to the endpoints in *separate* reviews.

Before you go any further on this review, I would **strongly suggest** that you open up a
design document for these ACLs.  Although the ACL you're proposing does accurately reflect
the _current_ state of the maintenance endpoint, there is some background that you do not
have.  We (the ones that wrote these endpoints) can guide you through this background more
effectively on a design document.


docs/authentication.md (line 14)
<https://reviews.apache.org/r/38399/#comment156296>

    Are you sure this is correct?  The ACL changes shouldn't change authentication, only authorization.



src/master/http.cpp (lines 1473 - 1504)
<https://reviews.apache.org/r/38399/#comment156297>

    Can you refactor this into a helper function?  No reason to copy-paste it three times.



src/master/http.cpp (lines 1516 - 1518)
<https://reviews.apache.org/r/38399/#comment156298>

    Note this pattern of continuation.  You'll want to use this instead of the `_continuation`
pattern.



src/master/master.hpp (lines 934 - 947)
<https://reviews.apache.org/r/38399/#comment156299>

    We strongly prefer the other pattern of continuation.  See the note above.


- Joseph Wu


On Sept. 17, 2015, 1:31 a.m., Zhiwei Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38399/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 1:31 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Bugs: mesos-2222
>     https://issues.apache.org/jira/browse/mesos-2222
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add ACLs for the maintenance HTTP endpoints
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md 1c22c5416caf66b28238fc181a255e51ed16d867 
>   docs/authorization.md 2a5e74782754e446184a297f91112e9f94077896 
>   include/mesos/authorizer/authorizer.hpp d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e

>   src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65 
>   src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
>   src/master/flags.cpp 80879611fbcfd764c9fc8f60a31613a9c8fc2364 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/master.hpp d48ef7c0da8978a5e02e69e055ff010585b20ceb 
>   src/tests/master_maintenance_tests.cpp 44785057f129a3e6a69f399f7d6db59d9d5c2e91 
>   src/tests/mesos.hpp 3db97aca921c9216d90384e1eb17030849516454 
> 
> Diff: https://reviews.apache.org/r/38399/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message