mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38447: Implemented a TODO to clean up host mounts irrelevant to the container in the container's mount namespace.
Date Thu, 17 Sep 2015 07:23:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38447/#review99359
-----------------------------------------------------------


Patch looks great!

Reviews applied: [38447]

All tests passed.

- Mesos ReviewBot


On Sept. 17, 2015, 6:22 a.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38447/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2015, 6:22 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3433
>     https://issues.apache.org/jira/browse/MESOS-3433
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented a TODO to clean up host mounts irrelevant to the container in the container's
mount namespace.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 99f939f8b254cf71b4c1c7829b5fa37abdc2771b

>   src/slave/containerizer/isolators/filesystem/linux.cpp b6746345b70b462123c3254065e4f09a42f45e5b

>   src/tests/containerizer/filesystem_isolator_tests.cpp ca9f423d5f2f8f838c3371ee596f07537bb45210

> 
> Diff: https://reviews.apache.org/r/38447/diff/
> 
> 
> Testing
> -------
> 
> Added a test that is not specific for this but observed successful cleanup of the other
container's mounts in logs.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message