> On Sept. 16, 2015, 10:42 p.m., Ben Mahler wrote:
> > Looks like you're missing the change to decoder. On that note, what happens when
we receive a response with a code that we haven't added to our enum?
>
> Timothy Chen wrote:
> You're right I missed the decoding part! Let me populate all the codes in the enum
and set it correctly.
>
> Ben Mahler wrote:
> Keep in mind that we still have to handle codes we don't have in our enum (some are
non-standard, we might receive something random, etc).
definitely, the existing code that checks the http map will still exist.
- Timothy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38416/#review99324
-----------------------------------------------------------
On Sept. 16, 2015, 1:03 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38416/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 1:03 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Jie Yu, Jojy Varghese, and Jiang Yan Xu.
>
>
> Bugs: MESOS-3429
> https://issues.apache.org/jira/browse/MESOS-3429
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Allow HTTP response codes to be checked with code.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
>
> Diff: https://reviews.apache.org/r/38416/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Timothy Chen
>
>
|