mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38046: mesos: Replaced hard-coded reap interval with a constant.
Date Wed, 16 Sep 2015 23:12:36 GMT


> On Sept. 16, 2015, 11:04 p.m., Ben Mahler wrote:
> > Whoops, it would be better for all of these to be process::MAX_REAP_INTERVAL() since
we'd like to move away from using entire the entire process namespace in the .cpp files.
> 
> Guangya Liu wrote:
>     OK, I will try to file another bug to resolve this. Thanks.

No need, I will fix it.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38046/#review99328
-----------------------------------------------------------


On Sept. 16, 2015, 4:07 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38046/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 4:07 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-1935
>     https://issues.apache.org/jira/browse/MESOS-1935
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> mesos: Replace hard-coded reap interval with a constant.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/launch_tests.cpp d211fc0f665988068c67836ef80916828a0df2bd 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
>   src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 
> 
> Diff: https://reviews.apache.org/r/38046/diff/
> 
> 
> Testing
> -------
> 
> Platform: Ubuntu 14.04
> make distcheck
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message