mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 38364: Minor refactor for MesosContainerizer.
Date Wed, 16 Sep 2015 22:00:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38364/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 6 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
-------

rebased


Bugs: MESOS-3387
    https://issues.apache.org/jira/browse/MESOS-3387


Repository: mesos


Description
-------

This change moves two different pieces of code, that each iterate over list of ContainerPrepareInfos,
close together for readability. It becomes even more relevant when looking at https://reviews.apache.org/r/38365/
that iterates over yet another member from ContainerPrepareInfo.


Diffs (updated)
-----

  src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03


Diff: https://reviews.apache.org/r/38364/diff/


Testing
-------

make  check


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message