mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 38417: Unified the implementations of image provisioners.
Date Wed, 16 Sep 2015 21:39:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38417/#review99279
-----------------------------------------------------------

Ship it!



src/slave/containerizer/provisioner/appc/store.cpp (line 49)
<https://reviews.apache.org/r/38417/#comment156191>

    Yup this is a better approach!



src/slave/containerizer/provisioner/provisioner.cpp (line 324)
<https://reviews.apache.org/r/38417/#comment156185>

    This is used as an alias? `const &` so it's more idiomatic?



src/slave/flags.cpp (lines 62 - 65)
<https://reviews.apache.org/r/38417/#comment156214>

    This is the first flag IIRC that we require that capital letters be used. It's no big
deal but my original code made it OK to use lower case "appc" is thoughtful and less error-prone
for operators at little cost for code complexity.



src/slave/flags.cpp (line 67)
<https://reviews.apache.org/r/38417/#comment156216>

    Assuming this is going to be changed to --image_provisioner_backend.



src/tests/containerizer/provisioner_appc_tests.cpp (lines 284 - 289)
<https://reviews.apache.org/r/38417/#comment156193>

    I was using this to test these paths::XYZ methods: Code being tested is using these methods
and the test itself is using literals to reconsturct the path.


- Jiang Yan Xu


On Sept. 15, 2015, 6:28 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38417/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:28 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Unified the implementations of image provisioners. See ticket for motivation.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 6cfe9fa2971d50f545587b57721f75a981f6d5ed

>   src/slave/containerizer/isolators/filesystem/linux.cpp dbdbf8722d088ef671b705c0c42191d0f9e05be9

>   src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03

>   src/slave/containerizer/provisioner/appc/provisioner.hpp 764b119edf670a44cff4719a2301b1baac88c78a

>   src/slave/containerizer/provisioner/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661

>   src/slave/containerizer/provisioner/appc/store.hpp c4ce4b90d71791c7fd558221cb2526b1ff245d3b

>   src/slave/containerizer/provisioner/appc/store.cpp 33f692c9b7780bdde96fddd8b07a2f4eb3452471

>   src/slave/containerizer/provisioner/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2

>   src/slave/containerizer/provisioner/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce

>   src/slave/containerizer/provisioner/provisioner.hpp 9e0e0b8ef290a31b67bd2415253408e811e1c720

>   src/slave/containerizer/provisioner/provisioner.cpp 2ac9008243b0dc2ba6051e75c508d183068cebcb

>   src/slave/containerizer/provisioner/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioner/store.cpp PRE-CREATION 
>   src/slave/flags.hpp 799c963806fadee814bac4b9bded679b0ebbbe9c 
>   src/slave/flags.cpp ff167ecd6ef224b061b37bbd3dbb4573448f8de2 
>   src/slave/paths.hpp 43c65af03a6af8d3d2d50f7c8366d7fbd26cb990 
>   src/slave/paths.cpp f104ecdbbb78093ccb968c0a01ea0924bfa391c5 
>   src/tests/containerizer/filesystem_isolator_tests.cpp ffa371fab69ce5eebe3b02afc2a1724a0f52110f

>   src/tests/containerizer/provisioner.hpp a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_appc_tests.cpp 8fee7ace4d8207796a5d3fb6d52fc25d002b783d

>   src/tests/paths_tests.cpp 1ccc5c70b06f44f54d843d6ed92e9105eda40a7b 
> 
> Diff: https://reviews.apache.org/r/38417/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message