mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Norman" <phil+apa...@propter.co.uk>
Subject Re: Review Request 38056: Fix webui task informations not update bug.
Date Wed, 16 Sep 2015 10:41:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38056/#review99207
-----------------------------------------------------------



src/webui/master/static/js/controllers.js (line 217)
<https://reviews.apache.org/r/38056/#comment156150>

    These metrics are not available on master, only directly from the slave nodes. 
    
    The webui redirects the user to master, so these metrics will never be available in the
UI, so I can't see a situation where this would work.
    
    It's not clear to me how this data could be gathered from master, and it would be impractical
to poll slaves directly, even assuming that the CORS restrictions were fixed.


- Philip Norman


On Sept. 14, 2015, 4:42 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38056/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 4:42 p.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, and Michael Park.
> 
> 
> Bugs: MESOS-3282
>     https://issues.apache.org/jira/browse/MESOS-3282
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix webui task informations not update bug.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js fbf86965efdb16f11787c24fb50d20af0837c62d

> 
> Diff: https://reviews.apache.org/r/38056/diff/
> 
> 
> Testing
> -------
> 
> Manual test, test scenarios:
> 
> * Normal scenarios updated after the new task is finished
> * After mesos-master down, could updated after reconnected
> 
> ![task_infomartions.png](https://issues.apache.org/jira/secure/attachment/12753783/task_infomartions.png)
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message