mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.
Date Wed, 16 Sep 2015 02:05:55 GMT 

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 10:05 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
-------

rebased


Bugs: MESOS-3013
    https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
-------

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs (updated)
-----

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
-------

make check.


Thanks,

Kapil Arya
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message