mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.
Date Tue, 15 Sep 2015 23:12:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review99115
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/CMakeLists.txt (lines 223 - 225)
<https://reviews.apache.org/r/37273/#comment155984>

    Just curious, why aren't you using the protobuf-2.5.0 tarball that's included in the mesos
source?
    
    I can imagine that you could use the included tarball for everything other than glog (which
requires 0.3.4+).
    
    See:
    https://github.com/apache/mesos/tree/master/3rdparty/libprocess/3rdparty



3rdparty/libprocess/3rdparty/CMakeLists.txt (line 249)
<https://reviews.apache.org/r/37273/#comment156001>

    There are a lot of over-80-character lines (in the existing cmake file too, but don't
change those in this patch).
    
    You'll want to space this line like:
    ```
      VS_BUILD_CMD(
          PROTOBUF 
          ${PROTOBUF_ROOT}/vsprojects/protobuf.sln 
          Release 
          "libprotobuf libprotoc protoc")
    ```



3rdparty/libprocess/cmake/macros/VsBuildCommand.bat (line 52)
<https://reviews.apache.org/r/37273/#comment156005>

    s/is not/does not/


- Joseph Wu


On Sept. 15, 2015, 11:42 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 11:42 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64

>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message