mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38143: Adding executor HTTP API protobuf to V1
Date Tue, 15 Sep 2015 22:40:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38143/#review99117
-----------------------------------------------------------

Ship it!


LGTM minus Two Nits:

1. Can we update the description of the review to just say that this change just copies the
existing unversioned protobuf to the V1 namespace.
2. I am assuming that you would take care of Vinod's earlier comment around `invalid calls
result in BadRequest` for `message Error` description in a separate patch as you had commented
earlier.

- Anand Mazumdar


On Sept. 15, 2015, 10:35 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38143/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 10:35 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-3375
>     https://issues.apache.org/jira/browse/MESOS-3375
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Executor protobufswere introduced in Mesos for the HTTP API, they need to be added to
/v1 so they reflect changes made on v1/mesos.proto. This protobuf ought to be changed as the
executor HTTP API design evolves.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/executor/executor.hpp PRE-CREATION 
>   include/mesos/v1/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 509256f 
> 
> Diff: https://reviews.apache.org/r/38143/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message