mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anand Mazumdar" <mazumdar.an...@gmail.com>
Subject Re: Review Request 38278: Updating unversioned Executor protobuf
Date Tue, 15 Sep 2015 22:10:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99109
-----------------------------------------------------------


Looks good, just a few more minor things. Also to save effort don't bother updating the corresponding
V1 review for now. You can just copy paste once the changes in this review is finalized.


include/mesos/executor/executor.proto (line 129)
<https://reviews.apache.org/r/38278/#comment155966>

    `message Subscribe` is not the first event received when the executor subscribes.
    
    Can we change the comment to:
    // Request to subscribe with the slave. If subscribing after a disconnection, it must
include a list of all the tasks and updates which haven't been acknowledged by the scheduler.



include/mesos/executor/executor.proto (line 160)
<https://reviews.apache.org/r/38278/#comment155967>

    Minor: Can we also have a comment before the `framework_id` field ?
    
    // Identifies the framework which generated this call.


- Anand Mazumdar


On Sept. 15, 2015, 9:32 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 9:32 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding last changes of the executor HTTP API design to the unversioned protobuf
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message