mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38278: Updating unversioned Executor protobuf
Date Tue, 15 Sep 2015 21:30:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38278/#review99102
-----------------------------------------------------------



include/mesos/executor/executor.proto (line 131)
<https://reviews.apache.org/r/38278/#comment155942>

    kill this.



include/mesos/executor/executor.proto (line 160)
<https://reviews.apache.org/r/38278/#comment155943>

    make this required.
    
    also add a "required FrameworkID framework_id" because executor id is only unique within
a framework.


- Vinod Kone


On Sept. 15, 2015, 8:13 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38278/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 8:13 p.m.)
> 
> 
> Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding last changes of the executor HTTP API design to the unversioned protobuf
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.proto 52c84b3 
> 
> Diff: https://reviews.apache.org/r/38278/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message