mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.
Date Tue, 15 Sep 2015 21:11:32 GMT


> On Sept. 14, 2015, 6:11 p.m., Niklas Nielsen wrote:
> > src/examples/test_hook_module.cpp, line 198
> > <https://reviews.apache.org/r/38368/diff/1/?file=1072969#file1072969line198>
> >
> >     How about setting the protocol (for testing)? So maybe have two network infos
(one with each)?

Apparently, the protocol is of no use for TaskStatus decorator. It's only used when requesting
IP (as mentioned in the comments for the protobuf). Dropping the issue. Feel free to reopen
if needed.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review98928
-----------------------------------------------------------


On Sept. 15, 2015, 5:10 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message