mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 37969: Maintenance primitives: Tweak validation error messages to return JSON rather than protobuf.
Date Tue, 15 Sep 2015 19:43:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37969/#review99079
-----------------------------------------------------------


Patch looks great!

Reviews applied: [37969]

All tests passed.

- Mesos ReviewBot


On Sept. 15, 2015, 12:10 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37969/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 12:10 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replaces `__.DebugString()` with `stringify(JSON::Protobuf(__))`, which looks nicer and
matches the JSON expected by the HTTP endpoints.
> 
> Addresses a comment found here: https://reviews.apache.org/r/37358/#comment152513
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp f7ce9aa56b453c1d37b99dd836d956ab292ab62e 
>   src/master/maintenance.cpp 87308a659db05f0676bd02a56ff41fe9d953ba71 
> 
> Diff: https://reviews.apache.org/r/37969/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> This change will tweak the output from:
> ```
> Machine 'hostname: "myComputer"
> ' is not valid because ...
> 
> ```
> (`DebugString` ^ puts a newline there.)
> 
> To: 
> ```
> Machine '{"hostname":"myComputer"}' is not valid because ...
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message