mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 38126: Add UT for QuiesceOffers
Date Tue, 15 Sep 2015 19:43:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38126/#review99078
-----------------------------------------------------------


you should've merged this test review with the dependent review. i really like tests to be
present in the same patch as the code change, to give me confidence that the code changes
are correct.

also, no tests for the scheduler driver?


src/tests/scheduler_tests.cpp (lines 1004 - 1005)
<https://reviews.apache.org/r/38126/#comment155911>

    // On revival scheduler should get another offer with the same amount of resources.
    
    also, i'm a bit confused on how/why the scheduler gets another offer (for the same resources)
considering the framework is holding on to the original offer?


- Vinod Kone


On Sept. 4, 2015, 12:06 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38126/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:06 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Ben Mahler, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3037
>     https://issues.apache.org/jira/browse/MESOS-3037
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add UT for QuiesceOffers
> 
> 
> Diffs
> -----
> 
>   src/tests/scheduler_tests.cpp 77c26353afc33f5099be2d1e597ffc630e559968 
> 
> Diff: https://reviews.apache.org/r/38126/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message