mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38407: Moved files to prepare for unifying provisioners.
Date Tue, 15 Sep 2015 18:40:12 GMT


> On Sept. 15, 2015, 6:38 p.m., Jiang Yan Xu wrote:
> > My only concern is whether this should be checked in before https://reviews.apache.org/r/38137/
as it's already in the review process for a long time. As long as Tim's OK with it.

r38137 has to fix problems in the provisioner (which is not updated according to the newest
appc provisioner). Having a unified provisioner first should be able to help get rid of many
code in that patch.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38407/#review99057
-----------------------------------------------------------


On Sept. 15, 2015, 6:07 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38407/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 6:07 p.m.)
> 
> 
> Review request for mesos, Timothy Chen and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3432
>     https://issues.apache.org/jira/browse/MESOS-3432
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Moved files to prepare for unifying provisioners. See ticket for motivation.
> 
> This is the first patch toward a unified provisioner. Expecting more subsequent patches.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 509256f40ecc1ff5b3a5ce2b380facd153137a18 
>   src/slave/containerizer/isolators/filesystem/linux.hpp 6cfe9fa2971d50f545587b57721f75a981f6d5ed

>   src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03

>   src/slave/containerizer/provisioner.hpp 9e0e0b8ef290a31b67bd2415253408e811e1c720 
>   src/slave/containerizer/provisioner.cpp 2ac9008243b0dc2ba6051e75c508d183068cebcb 
>   src/slave/containerizer/provisioners/appc/paths.hpp 37bbf090c5358321e0fa66e7287fac888df6f011

>   src/slave/containerizer/provisioners/appc/paths.cpp e598df090ce55108c68b83dc276e714a4e352939

>   src/slave/containerizer/provisioners/appc/provisioner.hpp 764b119edf670a44cff4719a2301b1baac88c78a

>   src/slave/containerizer/provisioners/appc/provisioner.cpp 77f9cbe778785bd93c30eba5dfd7a470d9258661

>   src/slave/containerizer/provisioners/appc/spec.hpp 63c79301154a68b58f2437d452025a8839359b12

>   src/slave/containerizer/provisioners/appc/spec.cpp 15a32578396459151891b462c2b6fdf499a371ea

>   src/slave/containerizer/provisioners/appc/store.hpp c4ce4b90d71791c7fd558221cb2526b1ff245d3b

>   src/slave/containerizer/provisioners/appc/store.cpp 33f692c9b7780bdde96fddd8b07a2f4eb3452471

>   src/slave/containerizer/provisioners/backend.hpp a25b4eaa1894178d4816cfbf1d9da2690bbe24bd

>   src/slave/containerizer/provisioners/backend.cpp 6560ece14d8618878a35d1bfe27db3958da64358

>   src/slave/containerizer/provisioners/backends/bind.hpp 61a883898ec170e7a61d04f78650f357de52ff0f

>   src/slave/containerizer/provisioners/backends/bind.cpp 71861a9c971d12be4d77c8c39e99f2de4746f60f

>   src/slave/containerizer/provisioners/backends/copy.hpp 2abca37ed2479d42c634c23cac8e40d515249988

>   src/slave/containerizer/provisioners/backends/copy.cpp b56946562525e79bef3a7387cd71f39fd0690683

>   src/slave/containerizer/provisioners/docker/registry_client.hpp b5e28587bc9adc2c02805b13fbc5c693612c99fb

>   src/slave/containerizer/provisioners/docker/registry_client.cpp b262ef031e0373ee009273e50a16d0a58ed83e8e

>   src/slave/containerizer/provisioners/docker/token_manager.hpp 879269dab9a53192a6d2ddebf20d2cc25effa262

>   src/slave/containerizer/provisioners/docker/token_manager.cpp aec915f25f6aada0a1d8f22d63a093bdbac97b25

>   src/slave/containerizer/provisioners/paths.hpp 5b82591fbe0d1ea48e4b09727424d0547f21adc2

>   src/slave/containerizer/provisioners/paths.cpp 4293dd2fe62bd6aee9243717916c86ff9e39d9ce

>   src/tests/containerizer/appc_provisioner_tests.cpp 8fee7ace4d8207796a5d3fb6d52fc25d002b783d

>   src/tests/containerizer/docker_provisioner_tests.cpp a3ccbc0fefa38f39e4fa06542c01af42c26df822

>   src/tests/containerizer/provisioner.hpp a26b8138d8cc3086058b15a797dd15354a84019f 
>   src/tests/containerizer/provisioner_backend_tests.cpp f2498b109c910fbf753a53b4b36a88b8d779aa69

> 
> Diff: https://reviews.apache.org/r/38407/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message