mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.
Date Tue, 15 Sep 2015 17:44:23 GMT


> On Sept. 11, 2015, 10:41 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/cmake/macros/VsBuildCommand.bat, line 22
> > <https://reviews.apache.org/r/37273/diff/6/?file=1065776#file1065776line22>
> >
> >     Rather than interpolating a `'#'` between the projects, can we pass in all the
projects as a list and loop through them here with a `for` instead? Something like:
> >     
> >     ```
> >     for %%I IN (%*) DO (... stuff goes here ...)
> >     ```

If we use this way, we would go into this trap:

* If we let `VsBuildCommand.bat` could works like `VsBuildCommand.bat xxx.sln project1 project2`,
we could not let CMake pass params like that. Cmake would wrap the build command with quotes,
and VisualStudio could not run it.
* If we want cmake could generate a command which could run in VisualStudio project file,
I think need use the old way.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37273/#review98687
-----------------------------------------------------------


On Sept. 15, 2015, 4:40 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37273/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 4:40 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and
Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add CMake macro VsBuildCommand in libprocess.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/CMakeLists.txt d13ba666740b4f2e382a0b1852724cfd519f8f64

>   3rdparty/libprocess/cmake/macros/Noop.cmake PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.bat PRE-CREATION 
>   3rdparty/libprocess/cmake/macros/VsBuildCommand.cmake PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message