mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38031: [3/5] Integer Precision for JSON <-> Protobuf conversions.
Date Tue, 15 Sep 2015 17:10:49 GMT


> On Sept. 15, 2015, 1:41 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 128
> > <https://reviews.apache.org/r/38031/diff/7/?file=1072999#file1072999line128>
> >
> >     Haha! Perhaps the most subtle C++11 feature.

You mean the comma at the end?  :)


> On Sept. 15, 2015, 1:41 a.m., Michael Park wrote:
> > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp, line 141
> > <https://reviews.apache.org/r/38031/diff/7/?file=1073002#file1073002line141>
> >
> >     We typically don't put underscores in our test names. They're usually reserved
for things like `DISABLED_*` and `ROOT_*`.

I'll rename it to `JsonLargeIntegers`.  (I put the underscore there because of the capital
`JSON`.)


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38031/#review98998
-----------------------------------------------------------


On Sept. 14, 2015, 1:37 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38031/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 1:37 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Michael
Park, and Vinod Kone.
> 
> 
> Bugs: MESOS-3345
>     https://issues.apache.org/jira/browse/MESOS-3345
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> * Changes JSON::Number to keep track of whether it is floating, signed integral, or unsigned
integral.
> * Changes how JSON::Number is stringified, to ensure that stringified doubles are parsed
as JSON doubles.
> * Added one test for integer precision between String <-> JSON <-> Protobuf
conversions.
> * Added one test for JSON::Number comparisons.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c4682c41e94ab6c7641a78d66b2f9daa5f

>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf45273c620655b44b5f5572290cffa4bf6

>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c269e9be24c0f1ae81b8aa8725f8a0c151

>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3098293eb3659b3066f10e875927ec3ac3

> 
> Diff: https://reviews.apache.org/r/38031/diff/
> 
> 
> Testing
> -------
> 
> No testing done until the last patch in the chain.
> 
> However, this patch does breaks some libprocess and mesos tests (because JSON::Number
is stored differently), which are fixed in the following two reviews.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message