mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.
Date Tue, 15 Sep 2015 14:18:47 GMT


> On Sept. 11, 2015, 10:49 p.m., Alex Clemmer wrote:
> > cmake/MesosConfigure.cmake, line 121
> > <https://reviews.apache.org/r/37275/diff/4/?file=1064668#file1064668line121>
> >
> >     Let me just double check that I understand this code. We're building a `make.bat`
file, but not because we use it here -- it's so others can include it when they make Mesos
from a different VS solution, right?

Yes.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review98701
-----------------------------------------------------------


On Sept. 5, 2015, 12:45 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message