mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 38253: Add containerId to ResourceUsage to enable QoS controller to target a container
Date Tue, 15 Sep 2015 13:08:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38253/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 1:08 p.m.)


Review request for mesos and Niklas Nielsen.


Changes
-------

Address comments


Bugs: MESOS-2875
    https://issues.apache.org/jira/browse/MESOS-2875


Repository: mesos


Description
-------

We should ensure that we are addressing the container which the QoS controller intended to
kill. Without this check, we may run into a scenario where the executor has terminated and
one with the same id has started in the interim i.e. running in a different container than
the one the QoS controller targeted.

This most likely requires us to add containerId to the ResourceUsage message and encode the
containerID in the QoS Correction message.


Diffs (updated)
-----

  include/mesos/mesos.proto b1deed4 
  include/mesos/slave/oversubscription.proto fa69a95 
  src/slave/slave.cpp 44865bd 
  src/tests/oversubscription_tests.cpp 0c5edaf 

Diff: https://reviews.apache.org/r/38253/diff/


Testing
-------

make
make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message