mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)
Date Tue, 15 Sep 2015 09:39:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38102/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 9:39 a.m.)


Review request for mesos and Ben Mahler.


Changes
-------

Address comments


Bugs: MESOS-3046
    https://issues.apache.org/jira/browse/MESOS-3046


Repository: mesos


Description
-------

__Phenomenon:__
Performance downgrade

__Root Cause:__
stout's UUID abstraction is re-seeding the random generator during each call to UUID::random(),
which is really expensive.

__Solution:__
Seeding the random generator only once per thread.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e90dabb 

Diff: https://reviews.apache.org/r/38102/diff/


Testing
-------

make
make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message