mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38172: Stout: Simplified hashset implementation.
Date Tue, 15 Sep 2015 00:26:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38172/#review98974
-----------------------------------------------------------


Just a drive by on comment wrapping changes.


3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp (lines 40 - 41)
<https://reviews.apache.org/r/38172/#comment155745>

    Let's avoid retroactively changing comment wrapping like this, since 80 isn't a hard requirement.
It would also be great if we could wrap to reduce jaggedness, I find the existing wrapping
easier to read, you?


- Ben Mahler


On Sept. 8, 2015, 9:52 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38172/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2015, 9:52 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3217
>     https://issues.apache.org/jira/browse/MESOS-3217
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp 1839d28638cd82dae10ba9b0f99c1a97cf34f9c9

> 
> Diff: https://reviews.apache.org/r/38172/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message