mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.
Date Tue, 15 Sep 2015 00:13:02 GMT


> On Sept. 14, 2015, 4:51 p.m., Qian Zhang wrote:
> > src/tests/master_maintenance_tests.cpp, line 418
> > <https://reviews.apache.org/r/37283/diff/6/?file=1071196#file1071196line418>
> >
> >     I checked v1/mesos.proto, and found regular offer also has unavailability:
> >     ```
> >     optional Unavailability unavailability = 9;
> >     ```

That comment is saying, "the first set of offers in this test should not have `unavailability`
set".

I think you misunderstood it to be: "offers don't have an `unavailability` field".


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37283/#review98964
-----------------------------------------------------------


On Sept. 13, 2015, 1:33 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37283/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 1:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_maintenance_tests.cpp fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37283/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message