mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 38102: MESOS-3046 (Stout's UUID re-seeds a new random generator during each call to UUID::random)
Date Mon, 14 Sep 2015 23:25:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38102/#review98950
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp (line 31)
<https://reviews.apache.org/r/38102/#comment155715>

    Please use THREAD_LOCAL from stout/thread_local.hpp and store a heap object as done in
all of our other uses of THREAD_LOCAL.


- Ben Mahler


On Sept. 5, 2015, 3:08 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38102/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 3:08 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3046
>     https://issues.apache.org/jira/browse/MESOS-3046
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> __Phenomenon:__
> Performance downgrade
> 
> __Root Cause:__
> stout's UUID abstraction is re-seeding the random generator during each call to UUID::random(),
which is really expensive.
> 
> __Solution:__
> Seeding the random generator only once per thread.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/uuid.hpp e90dabb0c572923a50490ecb17867dc50c6d161d

> 
> Diff: https://reviews.apache.org/r/38102/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message