mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 38374: Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.
Date Mon, 14 Sep 2015 23:09:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38374/#review98942
-----------------------------------------------------------

Ship it!


We should probably have a test case (or some checks in existing tests) for this. (and I should
add one for `provisioner::recover()` for orphans)


src/slave/containerizer/isolators/filesystem/linux.cpp (lines 134 - 139)
<https://reviews.apache.org/r/38374/#comment155706>

    Instead of doing it here and adding this block of comment we can put it in paths.hpp and
it's more obviously there and probably requires no additional comments.


- Jiang Yan Xu


On Sept. 14, 2015, 3:30 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38374/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 3:30 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3349
>     https://issues.apache.org/jira/browse/MESOS-3349
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added logics in LinuxFilesystemIsolator to recover and cleanup orphans.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/filesystem/linux.hpp ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94

>   src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9

>   src/slave/paths.hpp 35b0439e89193b0933b33b67450008b0da9bbae7 
>   src/slave/paths.cpp f5697fb5bbb40064a55c4465210dcbdcd8630c87 
> 
> Diff: https://reviews.apache.org/r/38374/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message