mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 38378: Minor cleanup in perf_tests.cpp.
Date Mon, 14 Sep 2015 23:02:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38378/#review98939
-----------------------------------------------------------



src/tests/containerizer/perf_tests.cpp (line 51)
<https://reviews.apache.org/r/38378/#comment155703>

    You are changing the semantic, the original test case is to verify a list of events which
contains one invalid event, you changed to to verify just one invalid event. They are different.
The original one makes more sense to me.


- Cong Wang


On Sept. 14, 2015, 10:57 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38378/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 10:57 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/perf_tests.cpp bef475e4b573f02b69f2c4dd6d1c6a6e10f34c38 
> 
> Diff: https://reviews.apache.org/r/38378/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message