mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Niklas Nielsen" <...@qni.dk>
Subject Re: Review Request 38365: Updated Isolator::prepare to return list of required namespaces.
Date Mon, 14 Sep 2015 22:50:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38365/#review98937
-----------------------------------------------------------

Ship it!



include/mesos/slave/isolator.proto (line 75)
<https://reviews.apache.org/r/38365/#comment155698>

    Taken we still wrap comments at 70, this needs to be wrapped :)


- Niklas Nielsen


On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38365/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 1:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3387
>     https://issues.apache.org/jira/browse/MESOS-3387
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the Isolators to decide whether or not to provide resource isolation
> on a per-container level.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/isolator.hpp 4db23dc242039607e6444d15aa800207b415ca02 
>   include/mesos/slave/isolator.proto 12ea6ac3552c70a172ae9e8506f4b5d96457a3ec 
>   src/slave/containerizer/isolator.hpp fbb7c8ab908192ae64f34e466c0c24705b3a134b 
>   src/slave/containerizer/isolator.cpp 7973100ea1a58938c50962120b9ecb6722b2ee4e 
>   src/slave/containerizer/isolators/filesystem/linux.hpp ab60f0ccffa06cb6f1913a6fd4fce8a2ccf6cd94

>   src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9

>   src/slave/containerizer/isolators/filesystem/shared.hpp a21bc79d342ece50c4924fc0ebd2186e57b3e899

>   src/slave/containerizer/isolators/filesystem/shared.cpp 4b4520e30ce1d1818bd3a13260f6dd55ab3900c9

>   src/slave/containerizer/isolators/namespaces/pid.hpp b22f5ba8e3743bb243ed2c5d204ab4ba21088630

>   src/slave/containerizer/isolators/namespaces/pid.cpp 35cb6645c9abc0cf533b844e2b2cccf4374bfd68

>   src/slave/containerizer/isolators/network/port_mapping.hpp 4bca0b81bf69fb4cd75e05aacd02d3e818e32d09

>   src/slave/containerizer/isolators/network/port_mapping.cpp 34ba2294b0bd7d57aa9de073692a2ea8ec62681d

>   src/slave/containerizer/mesos/containerizer.cpp 1b83a8725b35435531038e37188b4c97189cef03

>   src/tests/containerizer/isolator_tests.cpp d34c82a7f24da6f60cfb22790f516dc6065b1f6f

> 
> Diff: https://reviews.apache.org/r/38365/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message