mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 38333: Made container sandbox a shared mount to address MESOS-3349.
Date Mon, 14 Sep 2015 22:29:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38333/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 10:29 p.m.)


Review request for mesos, haosdent huang, Timothy Chen, Vinod Kone, and Jiang Yan Xu.


Changes
-------

Addressed comments. NNFR.


Bugs: MESOS-3349
    https://issues.apache.org/jira/browse/MESOS-3349


Repository: mesos


Description
-------

Made container sandbox a shared mount to address MESOS-3349.

See the discussion in https://reviews.apache.org/r/38329/ for more context.

The idea is to mark container sandbox a shared mount (do a self bind mount first) so that
persistent volume mounts can be propagated.

This is less invasive than marking '/' as a shared mount.

One followup for this patch is to set the default filesystem isolator to posix as the linux
isolator will manipulate host mount table.

We also need to address the TODO in `LinuxFilesystemIsolator::_recover` so that tests do not
leak mounts in the host mount table.


Diffs (updated)
-----

  src/slave/containerizer/isolators/filesystem/linux.cpp 0970b3d48b13d5e9d2e0160df5cf14a3dcd0acc9

  src/slave/containerizer/provisioners/appc/provisioner.cpp cd29a00fa0db8af294c10bb7a2e0cb4252bd2993

  src/slave/containerizer/provisioners/backends/bind.cpp 1cdae61786790dc6a475ae5f73c8cc92d2bbf739


Diff: https://reviews.apache.org/r/38333/diff/


Testing
-------

sudo make check on Centos5 and Centos6


Thanks,

Jie Yu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message