mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kapil Arya" <ka...@mesosphere.io>
Subject Review Request 38366: Added helper to model Labels message for state.json.
Date Mon, 14 Sep 2015 20:55:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38366/
-----------------------------------------------------------

Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Repository: mesos


Description
-------

Also updated Task modelling to show labels only if Task.has_labels() is true. This way, the
"labels" field won't shown if there are no labels. This makes it consistent with the modelling
of rest of the "optional" fields.


Diffs
-----

  src/common/http.hpp 61ad5314fb14cab0d1cec4fb855fb89b7ac8cf60 
  src/common/http.cpp 9c0d31e261788c492224345b9e0c32643ddb4156 
  src/common/protobuf_utils.cpp 08612700c456017638a9978e5fe9cfa466294c46 
  src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 

Diff: https://reviews.apache.org/r/38366/diff/


Testing
-------

make check


Thanks,

Kapil Arya


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message