mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Zhang" <zhang...@cn.ibm.com>
Subject Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.
Date Mon, 14 Sep 2015 14:52:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37180/#review98845
-----------------------------------------------------------



src/master/master.cpp (lines 4906 - 4907)
<https://reviews.apache.org/r/37180/#comment155463>

    Framework scheduler's resourceOffers() callback will be invoked to handle the "offers"
in ResourceOffersMessage, but here in the ResourceOffersMessage, we only set "pids" and "inverse_offers",
but not "offers". So that means framework scheduler will receive an empty offers? This seems
strange, maybe it is something that we need to fix in MESOS-2063 (Add InverseOffer to C++
Scheduler API)?


- Qian Zhang


On Sept. 14, 2015, 4:33 a.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37180/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 4:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
> 
> Diff: https://reviews.apache.org/r/37180/diff/
> 
> 
> Testing
> -------
> 
> The tests break as expected.
> With the scheduler API change there are CHECKs that fail.
> Once we update the API these will be resolved.
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message