mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField
Date Mon, 14 Sep 2015 05:15:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/
-----------------------------------------------------------

(Updated Sept. 14, 2015, 5:15 a.m.)


Review request for mesos and Michael Park.


Changes
-------

Add dependency to RB-38342, and remove `JSON::Protobuf`


Bugs: MESOS-3405
    https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
-------

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a `google::protobuf::Message`
into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing
overloaded functions.


Diffs (updated)
-----

  include/mesos/resources.hpp 6c3a065 
  src/common/http.cpp 9c0d31e 
  src/examples/persistent_volume_framework.cpp 426d338 
  src/launcher/executor.cpp 50b3c6e 
  src/master/contender.cpp 67562f1 
  src/master/http.cpp 73e8857 
  src/master/registrar.cpp d81560a 
  src/slave/containerizer/fetcher.cpp 2b2298c 
  src/slave/containerizer/mesos/containerizer.cpp 1b83a87 
  src/slave/monitor.cpp 8d8b422 
  src/tests/containerizer/launch_tests.cpp d211fc0 
  src/tests/fault_tolerance_tests.cpp 061e099 
  src/tests/http_api_tests.cpp 7938bbb 
  src/tests/master_maintenance_tests.cpp fb8dca3 
  src/tests/master_tests.cpp dd65fcc 
  src/tests/mesos.cpp ab2d85b 
  src/tests/reservation_endpoints_tests.cpp dfab497 
  src/tests/script.cpp bcc1fab 
  src/tests/slave_tests.cpp 447c43c 
  src/usage/main.cpp 86fd796 

Diff: https://reviews.apache.org/r/38335/diff/


Testing
-------

make
make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message