mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Review Request 38342: Add JSON::protobuf for google::protobuf::RepeatedPtrField (stout part)
Date Mon, 14 Sep 2015 05:10:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38342/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-3405
    https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
-------

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a `google::protobuf::Message`
into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing
overloaded functions.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d3 

Diff: https://reviews.apache.org/r/38342/diff/


Testing
-------

cd 3rdparty/libprocess/3rdparty/stout
./boostrap
./configure
make


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message