mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 37177: Maintenance Primitives: Added inverse offers.
Date Sun, 13 Sep 2015 20:42:26 GMT


> On Aug. 31, 2015, 1:56 p.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.hpp, line 1118
> > <https://reviews.apache.org/r/37177/diff/5/?file=1052923#file1052923line1118>
> >
> >     s/send inverse offer/deallocate resources/

This is tricky. We decided to use the word "de-allocate" in the allocator code. At the same
time, we're still using the "inverse offer" terminology elsewhere (in the master and scheduler
API), as well as in presentations and documentation. Considering the latter, I think it is
more usefull for users to see error messages using the "inverse offer" terminology.


> On Aug. 31, 2015, 1:56 p.m., Qian Zhang wrote:
> > src/master/master.cpp, line 623
> > <https://reviews.apache.org/r/37177/diff/5/?file=1052925#file1052925line623>
> >
> >     In future, we may need to add more callback functions, so here can we change
to use a general structure to keep the callback functions that we want to pass into allocator?
So in future, if we want to add more callback  functions, just need to change that structure
rather than the signature of allocator->initialize()

I understand your reasoning here. In this case I prefer making it "harder" on a developer
to modify the API, as the C++ compiler will guide them through all the consequences of changing
the API. If we turned this into a dynamic change of behavior, then it would increase the risk
of bugs or half-implemented features.

Regardless, this API will be getting some love (refactoring) in the near future, where some
of your concerns will be addressed :-)


- Joris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37177/#review97073
-----------------------------------------------------------


On Sept. 13, 2015, 8:33 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37177/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 8:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
>     https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/maintenance/maintenance.hpp 7fec3ffe063e766dcec4952001fa5c6e20d9eec8

>   include/mesos/master/allocator.hpp 659f37b3f9d9fa02da9bdb6c85cd3c180a24b73a 
>   src/master/allocator/mesos/allocator.hpp aa55755a9c3250579e9366bdbc17a2449e95d659 
>   src/master/allocator/mesos/hierarchical.hpp fbf353d8bdd4322275057e392a958fca77ecd8b3

>   src/master/master.hpp 12cc1ad45de3291ec22d4fe2b7ee11c4d7565c24 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/hierarchical_allocator_tests.cpp 9748ca0b38888fee25dcec51c64d8ba84dbd4aaf

>   src/tests/master_allocator_tests.cpp 89331965553505f6b7eebf39ad27d943df816a24 
>   src/tests/mesos.hpp 6b5031191b81a18f9596f547a1e0f67e35881cc3 
>   src/tests/reservation_endpoints_tests.cpp dfab4971e04a81ac98ed118ea877bcca5db17bb5

>   src/tests/reservation_tests.cpp aeee36752573e3f401d3dca7d2d69c90d0e8bd6b 
>   src/tests/resource_offers_tests.cpp 882a9ff4d09aace486182828bf43b643b0d0c519 
>   src/tests/slave_recovery_tests.cpp 6aae14a3c39b9aee76147b691b0170946e1120b5 
> 
> Diff: https://reviews.apache.org/r/37177/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message