mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField
Date Sun, 13 Sep 2015 16:39:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/#review98771
-----------------------------------------------------------


Bad patch!

Reviews applied: [38335]

Failed command: ./support/apply-review.sh -n -r 38335

Error:
 2015-09-13 16:39:45 URL:https://reviews.apache.org/r/38335/diff/raw/ [27283/27283] ->
"38335.patch" [1]
Successfully applied: Add JSON::protobuf for google::protobuf::RepeatedPtrField

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a `google::protobuf::Message`
into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing
overloaded functions.


Review: https://reviews.apache.org/r/38335
Checking 9 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  include/mesos/resources.hpp
  src/common/http.cpp
  src/master/http.cpp
  src/slave/containerizer/mesos/containerizer.cpp
  src/tests/reservation_endpoints_tests.cpp
stout:
  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto
Failed to commit patch

- Mesos ReviewBot


On Sept. 13, 2015, 4:19 p.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38335/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2015, 4:19 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-3405
>     https://issues.apache.org/jira/browse/MESOS-3405
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a
`google::protobuf::Message` into a `JSON::Object`.
> We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing
overloaded functions.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d3 
>   include/mesos/resources.hpp 6c3a065 
>   src/common/http.cpp 9c0d31e 
>   src/master/http.cpp 73e8857 
>   src/slave/containerizer/mesos/containerizer.cpp 1b83a87 
>   src/tests/reservation_endpoints_tests.cpp dfab497 
> 
> Diff: https://reviews.apache.org/r/38335/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message