mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <kl...@cguru.net>
Subject Review Request 38335: Add JSON::protobuf for google::protobuf::RepeatedPtrField
Date Sun, 13 Sep 2015 16:19:10 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38335/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Bugs: MESOS-3405
    https://issues.apache.org/jira/browse/MESOS-3405


Repository: mesos


Description
-------

Currently, `stout/protobuf.hpp` provides a `JSON::Protobuf` utility which converts a `google::protobuf::Message`
into a `JSON::Object`.
We should add the support for `google::protobuf::RepeatedPtrField<T>` by introducing
overloaded functions.


Diffs
-----

  3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp f28138c 
  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 57d5fdf 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 850650c 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp c56d6a3 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.h cfc2803 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.pb.cc a1d4084 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.proto bbd36d3 
  include/mesos/resources.hpp 6c3a065 
  src/common/http.cpp 9c0d31e 
  src/master/http.cpp 73e8857 
  src/slave/containerizer/mesos/containerizer.cpp 1b83a87 
  src/tests/reservation_endpoints_tests.cpp dfab497 

Diff: https://reviews.apache.org/r/38335/diff/


Testing
-------

make
make check


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message