mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam B" <a...@mesosphere.io>
Subject Re: Review Request 21713: Route overload to add auth HTTP Response + tests
Date Sat, 12 Sep 2015 09:47:59 GMT


> On May 20, 2014, 10:26 a.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/include/process/process.hpp, line 130
> > <https://reviews.apache.org/r/21713/diff/1/?file=585184#file585184line130>
> >
> >     this might be cleaner as an Option in the existing route method instead of an
overload.

Or you could default to an empty vector, which would give the same behavior as before.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21713/#review43499
-----------------------------------------------------------


On May 20, 2014, 10:20 a.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21713/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 10:20 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, and Dominic Hamon.
> 
> 
> Bugs: MESOS-1131
>     https://issues.apache.org/jira/browse/MESOS-1131
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Depends on : https://reviews.apache.org/r/21324/
> 3rd phase following Ben's comments on https://reviews.apache.org/r/19575/
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/base64.hpp 1f0944a 
>   3rdparty/libprocess/include/process/process.hpp c29cd21 
>   3rdparty/libprocess/src/process.cpp 58bae5b 
>   3rdparty/libprocess/src/tests/http_tests.cpp f58a129 
> 
> Diff: https://reviews.apache.org/r/21713/diff/
> 
> 
> Testing
> -------
> 
> Make check
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message