mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <clemmer.alexan...@gmail.com>
Subject Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.
Date Fri, 11 Sep 2015 22:49:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37275/#review98701
-----------------------------------------------------------



CMakeLists.txt (line 24)
<https://reviews.apache.org/r/37275/#comment155258>

    See note in previous review -- I'd rather uppercase the project name in the `VS_BUILD_CMD`
than have this floating around in global CMake scope.



CMakeLists.txt (line 44)
<https://reviews.apache.org/r/37275/#comment155257>

    Ah. I should have alphabetized these when I wrote them. Could we alphabetize them now?



cmake/MesosConfigure.cmake (line 121)
<https://reviews.apache.org/r/37275/#comment155260>

    Let me just double check that I understand this code. We're building a `make.bat` file,
but not because we use it here -- it's so others can include it when they make Mesos from
a different VS solution, right?


- Alex Clemmer


On Sept. 5, 2015, 12:45 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37275/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Generate make batch file to build project in windows.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3b6f4af337466d33cb915959a5995e4307b27be3 
>   cmake/MesosConfigure.cmake b530da4c1e6f202b682ad7d6892da95d2181f8c8 
> 
> Diff: https://reviews.apache.org/r/37275/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message