mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 38077: [5/5] Integer Precision for JSON <-> Protobuf conversions.
Date Fri, 11 Sep 2015 17:42:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38077/
-----------------------------------------------------------

(Updated Sept. 11, 2015, 10:42 a.m.)


Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, Timothy Chen,
and Vinod Kone.


Changes
-------

Rebase due to test fix and merge conflict.


Bugs: MESOS-3345
    https://issues.apache.org/jira/browse/MESOS-3345


Repository: mesos


Description
-------

* Add TODO's for refactoring some JSON parsing in the docker code (See MESOS-3409).  Update
how the JSON::Number is used.
* Tweak some tests to match changes to JSON::Number.
* Address a TODO on one test, which used a workaround for double-precision comparison.


Diffs (updated)
-----

  src/docker/docker.cpp 553e831029454d6d423842915b8bbfcaf19fa7f9 
  src/slave/containerizer/provisioners/docker/token_manager.cpp aec915f25f6aada0a1d8f22d63a093bdbac97b25

  src/tests/fault_tolerance_tests.cpp 89cb18be96cd60fb77fbcc4acd08cebdcf1ba075 
  src/tests/master_tests.cpp 8a6b98b9f59ead20f537eb60b5084feed069a5b1 
  src/tests/monitor_tests.cpp 53fb53eeea7d444ee043eb4569a52fead7ad0da8 
  src/tests/rate_limiting_tests.cpp f3aeddee00c7bb7905092aa8a760603468063126 
  src/tests/slave_tests.cpp 5c1a3d36a5f67629aef275eeae12956c524e8102 

Diff: https://reviews.apache.org/r/38077/diff/


Testing
-------

`make check`


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message