mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joris Van Remoortere" <joris.van.remoort...@gmail.com>
Subject Re: Review Request 37877: libprocess: Replace GCC instrinsics and volatile with std::atomic.
Date Fri, 11 Sep 2015 00:56:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37877/#review98522
-----------------------------------------------------------



3rdparty/libprocess/src/latch.cpp (line 41)
<https://reviews.apache.org/r/37877/#comment155021>

    renaming these to `expected`



3rdparty/libprocess/src/process.cpp (line 951)
<https://reviews.apache.org/r/37877/#comment155023>

    substituting the triple backticks to single backticks. sorry for the confusion.


- Joris Van Remoortere


On Sept. 10, 2015, 6:54 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37877/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2015, 6:54 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and switched to 'mcypark'.
> 
> 
> Bugs: MESOS-3326
>     https://issues.apache.org/jira/browse/MESOS-3326
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3326.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/latch.hpp a1a2227a9edcc31fd82c6410262aa4565fd66cb2

>   3rdparty/libprocess/include/process/metrics/counter.hpp e51a8beb80b15dd64aa2e481036ae8ba37125640

>   3rdparty/libprocess/include/process/process.hpp cc8317f1bc25bfa1be207a3e212b8cfc75248404

>   3rdparty/libprocess/src/clock.cpp 09c60e5a5d9bd9fc5511e57f3209fad7dbf834d6 
>   3rdparty/libprocess/src/latch.cpp f7d94d92e85c58878d98e13757b6fc37837ca977 
>   3rdparty/libprocess/src/process.cpp 0e5394acff16376809918d583d7aee582cc6da54 
>   3rdparty/libprocess/src/process_reference.hpp f8df4a6dcf01bb7af750c1ed9e85c64cea2042c5

> 
> Diff: https://reviews.apache.org/r/37877/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message